Jul 11, 2012 at 2:20 PM
Edited Jul 11, 2012 at 5:48 PM
I have created a fork, and 2 new branches. I'm now investigating how the code works.
There are pretty complex thing in it, and I will not touch it.
But some things are simpler, because they are in the “user” site (my site).
For example many (or all?) widgets use a rectangle as basic form. And many widgets have some variants of constructor to define this rectangle. I introduced the use of yours nana::rectangle deeper into
the class structure and the corresponding constructors. I hope this could simplify the documentation with one unified constructor for all widget (without the need for many different constructors), something like:
Wd (wd, const rectangle &r=rectangle(), bool visible=false );
and not necessary Wd (wd, x,y, w,h );
With is: Wd (wd, rectangle( point(x,y), size(w,h)) );
And for the create() function too.
These are minor changes that could be not very interesting for you. They are in branch rect of my fork. I don’t mind I expect you to introduce it in Nana, but just to inform you about.
I have read about your adoption of boost. It is good, very good. But I would like you to introduce only minimal dependences that could significantly affect the installation and use of Nana. (I installed
Boost with precompiled lib and it toke 1Gb!). I hope you select something smaller dependencies.
Talking about Boost, it will be good if you use their filesystem lib. This lib is in revision 2 for approval into a std c++ lib. I thing using it is a guarantee for a future.
Now I have the new Nana Cpp11 version from you. Good. But a think Nana have now 4 variant of the sources: Cpp03, Cpp11 with Linux and win32 each. It could be very difficult to you to maintain all in
parallel. Maybe they could be better something like one branches for each? I’m not sure…